switch electron to 0.37.8 to temp fix broken 0.30.0 #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ofTheo i run with newest electron, and i don't know why some part is worked, some features is not worked... main problems of about updating to newer electron is around ipc. |
@2bbb that would be amazing. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.30.0 is erring when fetching as mentioned in #342
This doesn't solve the arm64 issue or the fact that electron-prebuilt is super out of date but it does fix immediate issues.
We still need to bring electron up to date, but that means a rewrite of index.js and app.js
@2bbb curious if these changes work for you?